Implement Stage A: rule engine, validation, audit, and safety gates

Completes 109 of 121 tasks. Every remaining task needs a tenant connection
(T055, T056, T101-T103) or an Azure Automation account (T115-T121).

  354 offline Pester tests      PASS
  Engine purity (Principle IV)  PASS
  Sanitization (SC-013)         PASS  (156 files)
  Graph module loaded in tests  none  (SC-008 holds)

What landed
  - Four-layer configuration validation with stable finding codes, covering
    every VR-002 and VR-003 condition, plus a 23-fixture invalid-config corpus
  - Run loop, audit records (NDJSON through a single sink), summaries,
    reconciliation, and exit codes 0-6
  - Persistence behind a single write-body builder whose result always has
    exactly one key
  - Invoke-PersonaEngine.ps1 and Edit-PersonaEngineConfig.ps1
  - Six docs, two pipelines, traceability matrix, V-5a and sanitization records

Three deviations from tasks.md, each recorded in its status block

  T033 is not in Resolve-UserPersona. evaluationErrorThreshold is run-level
  state and the rule engine is pure; a counter there would break Principle IV.
  It lives in New-PersonaRunCounter and is applied in the run loop.

  A new src/Engine/ layer holds Invoke-PersonaEngineRun. The entry script
  imports the manifest, which requires Microsoft.Graph.Authentication, so a
  loop living only inside it could not run on a machine without the Graph SDK
  and SC-004 could not be proven at all. The entry script is now a thin
  wrapper and what ships is what is tested.

  The invalid-config corpus is generated by a committed script, with the
  generated fixtures committed too, so a reviewer sees the fixture in the diff.

Defects found by running the code, not by reading it

  Group and role ID lists were double-wrapped: @(Get-PersonaGroupIdPage ...)
  around a comma-returned array collapsed every membership list into one
  bogus space-joined entry. That is a silent false non-match, exactly what
  FR-013 exists to prevent.

  A 403 whose status appears only in the exception message parsed as $null,
  which the retry policy treats as a transport error - five requests per
  account against a tenant already refusing. Status extraction now falls back
  to the message text, bounded to 400-599.

  The sanitization scan walked tracked files only, so it covered 34 of 156
  files and none of this phase's code. It now scans untracked non-ignored
  files too, and a negative control confirms it catches a planted leak.

  Test-Json reports one error per violating location, not first-failure-only
  as the V-5a draft claimed. Record and pin corrected.

Enforcement remains blocked on the V-4 security sign-off.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
2026-08-20 21:48:19 -04:00
parent c59c85dd55
commit cdc6bb33d3
124 changed files with 16638 additions and 199 deletions
@@ -0,0 +1,109 @@
#Requires -Modules @{ ModuleName = 'Pester'; ModuleVersion = '5.0.0' }
<#
VR-003: traceConditionValues without explicit acknowledgement is a safety finding.
The acknowledgement lives in the configuration rather than in a command-line
switch, and that placement is the point. A flag passed at the console is invisible
to review; a field in the configuration appears in the diff of the change that
enables tracing, next to the person who approved it.
#>
BeforeAll {
$repoRoot = Split-Path (Split-Path $PSScriptRoot -Parent) -Parent
. (Join-Path $repoRoot 'tests/TestHelpers.ps1')
foreach ($file in (Get-PersonaSourceFile -RepoRoot $repoRoot)) { . $file }
$script:schema = Join-Path $repoRoot 'config/persona-engine.schema.json'
$script:scratch = Join-Path ([System.IO.Path]::GetTempPath()) ("pe-trace-{0}" -f [guid]::NewGuid().ToString('N'))
$null = New-Item -ItemType Directory -Path $script:scratch -Force
}
AfterAll {
Remove-Item -LiteralPath $script:scratch -Recurse -Force -ErrorAction SilentlyContinue
}
Describe 'Tracing acknowledgement (VR-003)' {
It 'produces PE-SAF-006 when tracing is on and acknowledgement is absent' {
$document = New-TestConfigurationDocument
$document.logging = @{ destination = 'stream'; traceConditionValues = $true }
$path = Save-TestConfiguration -Document $document -Directory $script:scratch
$result = Test-PersonaConfiguration -Path $path -SchemaPath $script:schema
$result.IsValid | Should -BeFalse
$result.Findings.Code | Should -Contain 'PE-SAF-006'
}
It 'produces PE-SAF-006 when acknowledgement is present but false' {
$document = New-TestConfigurationDocument
$document.logging = @{ destination = 'stream'; traceConditionValues = $true; acknowledgeConditionTracing = $false }
$path = Save-TestConfiguration -Document $document -Directory $script:scratch
$result = Test-PersonaConfiguration -Path $path -SchemaPath $script:schema
$result.Findings.Code | Should -Contain 'PE-SAF-006'
}
It 'accepts tracing when acknowledgement is true' {
$document = New-TestConfigurationDocument
$document.logging = @{ destination = 'stream'; traceConditionValues = $true; acknowledgeConditionTracing = $true }
$path = Save-TestConfiguration -Document $document -Directory $script:scratch
$result = Test-PersonaConfiguration -Path $path -SchemaPath $script:schema
$result.IsValid | Should -BeTrue
$result.Findings.Code | Should -Not -Contain 'PE-SAF-006'
}
It 'does not require acknowledgement when tracing is off' {
# Acknowledging something that is not happening would train people to set the
# field reflexively, which is how an acknowledgement stops meaning anything.
$document = New-TestConfigurationDocument
$document.logging = @{ destination = 'stream'; traceConditionValues = $false }
$path = Save-TestConfiguration -Document $document -Directory $script:scratch
$result = Test-PersonaConfiguration -Path $path -SchemaPath $script:schema
$result.IsValid | Should -BeTrue
$result.Findings.Code | Should -Not -Contain 'PE-SAF-006'
}
It 'blocks the run: the finding is an Error, not a Warning' {
$document = New-TestConfigurationDocument
$document.logging = @{ destination = 'stream'; traceConditionValues = $true }
$path = Save-TestConfiguration -Document $document -Directory $script:scratch
$result = Test-PersonaConfiguration -Path $path -SchemaPath $script:schema
($result.Findings | Where-Object Code -EQ 'PE-SAF-006').Severity | Should -Be 'Error'
}
It 'explains what tracing actually widens, not merely that it is enabled' {
$document = New-TestConfigurationDocument
$document.logging = @{ destination = 'stream'; traceConditionValues = $true }
$path = Save-TestConfiguration -Document $document -Directory $script:scratch
$finding = (Test-PersonaConfiguration -Path $path -SchemaPath $script:schema).Findings |
Where-Object Code -EQ 'PE-SAF-006'
$finding.Description | Should -Match 'attribute values'
$finding.SuggestedResolution | Should -Match 'acknowledgeConditionTracing'
}
}
Describe 'The schema accepts the acknowledgement field' {
It 'validates a configuration carrying acknowledgeConditionTracing' {
# additionalProperties is false on the logging block, so the field has to be
# declared in the schema or the acknowledgement itself becomes a schema error.
$document = New-TestConfigurationDocument
$document.logging = @{ destination = 'both'; path = '<LOG-OUTPUT-PATH>'; traceConditionValues = $true; acknowledgeConditionTracing = $true }
$path = Save-TestConfiguration -Document $document -Directory $script:scratch
$result = Test-PersonaConfiguration -Path $path -SchemaPath $script:schema
$result.Findings.Code | Should -Not -Contain 'PE-SCH-001'
}
}