Implement Stage A: rule engine, validation, audit, and safety gates

Completes 109 of 121 tasks. Every remaining task needs a tenant connection
(T055, T056, T101-T103) or an Azure Automation account (T115-T121).

  354 offline Pester tests      PASS
  Engine purity (Principle IV)  PASS
  Sanitization (SC-013)         PASS  (156 files)
  Graph module loaded in tests  none  (SC-008 holds)

What landed
  - Four-layer configuration validation with stable finding codes, covering
    every VR-002 and VR-003 condition, plus a 23-fixture invalid-config corpus
  - Run loop, audit records (NDJSON through a single sink), summaries,
    reconciliation, and exit codes 0-6
  - Persistence behind a single write-body builder whose result always has
    exactly one key
  - Invoke-PersonaEngine.ps1 and Edit-PersonaEngineConfig.ps1
  - Six docs, two pipelines, traceability matrix, V-5a and sanitization records

Three deviations from tasks.md, each recorded in its status block

  T033 is not in Resolve-UserPersona. evaluationErrorThreshold is run-level
  state and the rule engine is pure; a counter there would break Principle IV.
  It lives in New-PersonaRunCounter and is applied in the run loop.

  A new src/Engine/ layer holds Invoke-PersonaEngineRun. The entry script
  imports the manifest, which requires Microsoft.Graph.Authentication, so a
  loop living only inside it could not run on a machine without the Graph SDK
  and SC-004 could not be proven at all. The entry script is now a thin
  wrapper and what ships is what is tested.

  The invalid-config corpus is generated by a committed script, with the
  generated fixtures committed too, so a reviewer sees the fixture in the diff.

Defects found by running the code, not by reading it

  Group and role ID lists were double-wrapped: @(Get-PersonaGroupIdPage ...)
  around a comma-returned array collapsed every membership list into one
  bogus space-joined entry. That is a silent false non-match, exactly what
  FR-013 exists to prevent.

  A 403 whose status appears only in the exception message parsed as $null,
  which the retry policy treats as a transport error - five requests per
  account against a tenant already refusing. Status extraction now falls back
  to the message text, bounded to 400-599.

  The sanitization scan walked tracked files only, so it covered 34 of 156
  files and none of this phase's code. It now scans untracked non-ignored
  files too, and a negative control confirms it catches a planted leak.

  Test-Json reports one error per violating location, not first-failure-only
  as the V-5a draft claimed. Record and pin corrected.

Enforcement remains blocked on the V-4 security sign-off.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
2026-08-20 21:48:19 -04:00
parent c59c85dd55
commit cdc6bb33d3
124 changed files with 16638 additions and 199 deletions
+82
View File
@@ -0,0 +1,82 @@
#Requires -Modules @{ ModuleName = 'Pester'; ModuleVersion = '5.0.0' }
BeforeAll {
$repoRoot = Split-Path (Split-Path $PSScriptRoot -Parent) -Parent
foreach ($f in @(
'src/Normalization/New-PersonaMembershipRecord.ps1'
'src/Normalization/New-PersonaUserRecord.ps1'
'src/RuleEngine/Test-PersonaCondition.ps1'
'src/RuleEngine/Test-PersonaConditionGroup.ps1'
'src/RuleEngine/Test-PersonaRule.ps1'
'src/RuleEngine/Resolve-UserPersona.ps1'
)) { . (Join-Path $repoRoot $f) }
$script:user = New-PersonaUserRecord `
-AccountObjectId '00000000-0000-0000-0000-000000000105' `
-UserPrincipalName 'ellis.minimal@example.invalid' `
-UserType 'Member' `
-StoredPersona 'Employee'
function New-NonMatchingRule {
param([string] $Id, [int] $Priority)
[pscustomobject]@{
id = $Id; priority = $Priority; persona = 'Tier0-Admin'; enabled = $true
match = [pscustomobject]@{
operator = 'all'
conditions = @([pscustomobject]@{ type = 'property'; property = 'Department'; operator = 'equals'; value = 'NoSuchDepartment' })
}
}
}
}
Describe 'Unclassified outcome (FR-010)' {
It 'is the result when every enabled rule evaluates successfully and none match' {
$result = Resolve-UserPersona -UserRecord $user -Rules @(
New-NonMatchingRule -Id 'R-010' -Priority 10
New-NonMatchingRule -Id 'R-020' -Priority 20
)
$result.Outcome | Should -Be 'Unclassified'
$result.CalculatedPersona | Should -Be 'Unclassified'
$result.MatchedRuleId | Should -BeNullOrEmpty
}
It 'evaluates every enabled rule before concluding' {
$result = Resolve-UserPersona -UserRecord $user -Rules @(
New-NonMatchingRule -Id 'R-010' -Priority 10
New-NonMatchingRule -Id 'R-020' -Priority 20
New-NonMatchingRule -Id 'R-030' -Priority 30
)
$result.RulesEvaluated | Should -Be 3
}
It 'is the result for an empty rule set' {
$result = Resolve-UserPersona -UserRecord $user -Rules @()
$result.Outcome | Should -Be 'Unclassified'
}
It 'is the result when every rule is disabled' {
$disabled = New-NonMatchingRule -Id 'R-010' -Priority 10
$disabled.enabled = $false
$result = Resolve-UserPersona -UserRecord $user -Rules @($disabled)
$result.Outcome | Should -Be 'Unclassified'
$result.RulesEvaluated | Should -Be 0
}
It 'is reported distinctly from EvaluationError' {
# Both mean "no persona was assigned", but only one means the engine failed.
# Conflating them would hide data-availability problems inside a normal-
# looking result bucket.
$result = Resolve-UserPersona -UserRecord $user -Rules @(New-NonMatchingRule -Id 'R-010' -Priority 10)
$result.Outcome | Should -Not -Be 'EvaluationError'
$result.EvaluationErrorReason | Should -BeNullOrEmpty
}
It 'preserves the stored persona on the result for later comparison' {
(Resolve-UserPersona -UserRecord $user -Rules @(New-NonMatchingRule -Id 'R-010' -Priority 10)).StoredPersona |
Should -Be 'Employee'
}
}